Re: Please test: scrypt 1.2.99

[James Turner <james@calminferno.net>]

On Mon, Jul 01, 2019 at 10:27:38AM -0700, Graham Percival wrote:
> On Mon, Jul 01, 2019 at 09:56:24AM -0700, Colin Percival wrote:
> > We worked around a problem with some compilers which didn't understand
> > 'restrict' unless they were passed -std=c99, but I don't remember running
> > into systems which specifically failed with qualifiers in a function
> > declaration.
> 
> 2018-October:
> https://github.com/Tarsnap/scrypt/issues/150#issuecomment-427200652
> 
> > If -std=c99 fixes this, we should adjust posix-restrict.c.
> 
> Does not fix it.
> 
> The problem is caused by:
> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=14050
> which fixed in 2007-11-22. GCC 4.2.2 was 2007-10-07, so presumably the first
> release which might include it was 4.2.3 or possibly 4.3.0.
> 

I wouldn't worry about this too much, for modern archs OpenBSD ships
with llvm and for most others we have newer version of gcc in ports that can
be used in llvm isn't supported for those archs. I was testing on amd64
and everything works just fine with OpenBSD clang version 8.0.0
(tags/RELEASE_800/final) (based on LLVM 8.0.0).

-- 
James Turner