tarsnap crashing bug

[Colin Percival <cperciva@freebsd.org>]

Hi Tarsnap users,

About 24 hours ago a Tarsnap user reported a bug in version 1.0.34 of the
Tarsnap client which was causing it to crash, apparently related to the
handling of interruptions in network connectivity.  I have just found and
fixed a bug which is consistent with the reported crash; but I'd like to
rule out the possibility that there is another bug I have yet to find.

If you are running Tarsnap 1.0.34 and have seen it unexpectedly error out
or core dump, please let me know.

I have attached a patch which fixes the bug I've found; I will be rolling
a new Tarsnap 1.0.35 in the next few days.  Obviously, I'd like to make
sure that I don't need to roll a Tarsnap 1.0.36 a few days later...

Thanks,
-- 
Colin Percival
Security Officer Emeritus, FreeBSD | The power to serve
Founder, Tarsnap | www.tarsnap.com | Online backups for the truly paranoid

--- ./libcperciva/network/network_connect.c	2013-06-26 01:03:21.000000000 -0700
+++ ./libcperciva/network/network_connect.c	2013-07-22 22:21:45.000000000 -0700
@@ -104,6 +104,9 @@
 	/* We're not waiting for a timer callback any more. */
 	C->cookie_timeo = NULL;
 
+	/* Stop listening for this socket. */
+	events_network_cancel(C->s, EVENTS_NETWORK_OP_WRITE);
+
 	/* This connect attempt failed. */
 	return (dofailed(C));
 }