[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Exclude patterns



--As of June 29, 2014 6:04:01 AM -0700, jerry is alleged to have said:

Fair warning:  I am not an expert Perl programmer.  This thing seems to
work, but YMMV and
if your computer blows up into coruscating sparks, it's not my fault

--As for the rest, it is mine.

Could use a bit of a cleanup - there is evidence of your development process in the code - but it's not horrible. ;)

The one major thing is that you never close your big if statement (`if ( -e $excludes_filename )`). I think that means this will work fine until the first time you run it on a directory without an excludes file - when it will silently do nothing.

Daniel T. Staal

---------------------------------------------------------------
This email copyright the author.  Unless otherwise noted, you
are expressly allowed to retransmit, quote, or otherwise use
the contents for non-commercial purposes.  This copyright will
expire 5 years after the author's death, or in 30 years,
whichever is longer, unless such a period is in excess of
local copyright law.
---------------------------------------------------------------