[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Please test: scrypt 1.3.2.99



On 2025-02-04, Simon Josefsson wrote:
> Colin Percival <cperciva@tarsnap.com> writes:
> > Please test this, even if all you have time to do is check that it compiles
> > on your platform -- there are some build changes which we'd like to verify
> > on as many platforms as possible.
> 
> I got some deprecation warnings on Debian sid below, I'm not sure if
> that is intentional to allow compilation on earlier OpenSSL versions or
> a real problem.

Thanks for checking!

Hmm, I'd say this is a problem [1].  The build changes we made were
supposed to eliminate those warnings.

Could you please send me:

- apisupport-config.h (from the compiled scrypt directory)
- what compiler you used?

On my FreeBSD and Ubuntu 22.04 systems, with clang and gcc I see:
    $ more apisupport-config.h
    #define APISUPPORT_NONPOSIX_MEMLIMIT 1
    #define APISUPPORT_LIBCRYPTO_LOW_LEVEL_AES 1
    #ifdef apisupport_dummy
    export CFLAGS_LIBCRYPTO_LOW_LEVEL_AES="-Wno-deprecated-declarations"
    #endif

which takes care of those warnings.

[1] To be pedantic, the "deprecated warnings" don't mean that scrypt
will fail to run or will be insecure.  But we want to suppress those
warnings to avoid people wondering what's wrong.

Cheers,
- Graham