On Tue, Jan 21, 2025 at 03:10:10PM -0800, Graham Percival wrote: > On 2025-01-21, Peter Pentchev wrote: > > > * portability and standards compliance fixes. > > > > Thanks for the fix for the OpenSSL 3.x deprecated functions! > > I kept meaning to drop you a note about that (there was a Debian patch that > > defined OPENSSL_SUPPRESS_DEPRECATED), and I kept putting it off... > > I've wondered about using OPENSSL_SUPPRESS_DEPRECATED, but I'm not > convinced that it's intended to be public. That #define is not in > NEWS.md; it's mentioned in CHANGES.md, but in the context of > configuration headers and "internal hacks". > > Our current method is: > - try to compile with AES_encrypt() > - if that fails, add -Wno-deprecated to CFLAGS and try again; if the > modified attempt succeeds, add it to the CFLAGS for the relevant > files. > > I'm not certain this is the best method, but I think it's slightly safer > than OPENSSL_SUPPRESS_DEPRECATED. Nah, I only mentioned OPENSSL_SUPPRESS_DEPRECATED as the workaround that we used in the Debian package. I fully agree that it is not meant to be used seriously. What you're doing now works great, thanks! Hm, come to think of it, I've only tested it on amd64... I shall test it on some other Debian architectures tomorrow, but it is getting too late now, sorry :( G'luck, Peter -- Peter Pentchev roam@ringlet.net roam@debian.org peter@morpheusly.com PGP key: https://www.ringlet.net/roam/roam.key.asc Key fingerprint 2EE7 A7A5 17FC 124C F115 C354 651E EFB0 2527 DF13
Attachment:
signature.asc
Description: PGP signature