On Wed, Jan 22, 2025 at 02:08:43AM +0200, Peter Pentchev wrote: > On Tue, Jan 21, 2025 at 03:10:10PM -0800, Graham Percival wrote: > > On 2025-01-21, Peter Pentchev wrote: > > > > * portability and standards compliance fixes. > > > > > > Thanks for the fix for the OpenSSL 3.x deprecated functions! > > > I kept meaning to drop you a note about that (there was a Debian patch that > > > defined OPENSSL_SUPPRESS_DEPRECATED), and I kept putting it off... > > > > I've wondered about using OPENSSL_SUPPRESS_DEPRECATED, but I'm not > > convinced that it's intended to be public. That #define is not in > > NEWS.md; it's mentioned in CHANGES.md, but in the context of > > configuration headers and "internal hacks". > > > > Our current method is: > > - try to compile with AES_encrypt() > > - if that fails, add -Wno-deprecated to CFLAGS and try again; if the > > modified attempt succeeds, add it to the CFLAGS for the relevant > > files. > > > > I'm not certain this is the best method, but I think it's slightly safer > > than OPENSSL_SUPPRESS_DEPRECATED. > > Nah, I only mentioned OPENSSL_SUPPRESS_DEPRECATED as the workaround that > we used in the Debian package. I fully agree that it is not meant to > be used seriously. What you're doing now works great, thanks! > > Hm, come to think of it, I've only tested it on amd64... I shall > test it on some other Debian architectures tomorrow, but it is > getting too late now, sorry :( Actually I went ahead and uploaded a Debian package to the experimental suite; if it is accepted automatically (which should happen within the next hour or so), the build status and logs should start to appear at https://buildd.debian.org/status/package.php?p=spiped&suite=experimental So we'll see how it fares on the other architectures. For reference, 1.6.2 built fine everywhere except on the Hurd, and I didn't really spend much time trying to figure out why the tests timed out, but, for reference, it built fine everywhere else: https://buildd.debian.org/status/package.php?p=spiped&suite=unstable G'luck, Peter -- Peter Pentchev roam@ringlet.net roam@debian.org peter@morpheusly.com PGP key: https://www.ringlet.net/roam/roam.key.asc Key fingerprint 2EE7 A7A5 17FC 124C F115 C354 651E EFB0 2527 DF13
Attachment:
signature.asc
Description: PGP signature